Skip to content
This repository has been archived by the owner on Jun 1, 2023. It is now read-only.

Fix proxy to redirect to host and port set by cli #2607

Merged
merged 1 commit into from
Sep 9, 2022

Conversation

mgmanzella
Copy link
Contributor

WHY are these changes introduced?

Fixes #2606

WHAT is this pull request doing?

Use the host and port set by the cli to replace URLs in the proxy. Before it defaulted to 127.0.0.1:9292 but this isn't correct for extension serve

How to test your changes?

Testing steps assume you have a theme app extension (TAE) created

  • Create a new dev store
  • Run extension serve in your TAE
  • In your browser go to http://127.0.0.1:8282
  • Confirm you're redirected to the store password page
  • Input your password and confirm you can get into the store
fix_redirect_proxy.mp4

@mgmanzella mgmanzella requested review from a team and karreiro September 8, 2022 16:23
@mgmanzella mgmanzella merged commit 914d1ed into main Sep 9, 2022
@mgmanzella mgmanzella deleted the fix-proxy-default branch September 9, 2022 13:41
@amcaplan amcaplan restored the fix-proxy-default branch September 11, 2022 11:14
@amcaplan amcaplan deleted the fix-proxy-default branch September 11, 2022 11:14
@amcaplan amcaplan mentioned this pull request Sep 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BugHunt]: extension serve doesn't redirect to store password page for TAE
2 participants