Merge pull request #1496 from Shopify/nelsonwittwer/reorg_errors

Fix webhook error throwing
Shopify · Sep 1, 2022 · 77307bd · 77307bd
2 parents 0352f6a + 34af622
commit 77307bd
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/lib/shopify_app/managers/webhooks_manager.rb b/lib/shopify_app/managers/webhooks_manager.rb
@@ -64,7 +64,7 @@ def path(webhook_attributes)
         elsif uri&.path&.present?
           uri.path
         else
-          raise ShopifyApp::MissingWebhookJobError("The :path attribute is required for webhook registration.")
+          raise ShopifyApp::MissingWebhookJobError, "The :path attribute is required for webhook registration."
         end
       end
 

diff --git a/test/shopify_app/managers/webhooks_manager_test.rb b/test/shopify_app/managers/webhooks_manager_test.rb
@@ -55,6 +55,20 @@ class ShopifyApp::WebhooksManagerTest < ActiveSupport::TestCase
     ShopifyApp::WebhooksManager.add_registrations
   end
 
+  test "#add_registrations raises an error when missing path and address" do
+    ShopifyApp.configure do |config|
+      config.webhooks = [
+        {
+          topic: "orders/updated",
+        },
+      ]
+    end
+
+    assert_raises ShopifyApp::MissingWebhookJobError do
+      ShopifyApp::WebhooksManager.add_registrations
+    end
+  end
+
   test "#add_registrations does not makes calls to library's add_registration when there are no webhooks" do
     ShopifyAPI::Webhooks::Registry.expects(:add_registration).never
     ShopifyApp.configure do |config|