Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedded app loads OK on Chrome, but not on Firefox or Safari #1417

Closed
1 task done
fairknowe opened this issue Apr 20, 2022 · 3 comments
Closed
1 task done

Embedded app loads OK on Chrome, but not on Firefox or Safari #1417

fairknowe opened this issue Apr 20, 2022 · 3 comments
Assignees

Comments

@fairknowe
Copy link

Description

Embedded app loads OK on Chrome, but not on Firefox or Safari. See forum post for picture.

Steps to Reproduce

  1. bundle init
  2. bundle add shopify-cli
  3. bundle add dotenv-rails
  4. shopify login
  5. shopify app create rails (answering yes to public app)
  6. shopify app serve
  7. install app on Chrome, confirm install. Uninstall and repeat for Firefox & Safari

Expected behavior:

The app admin iframe should load with list of products in each browser

Actual behavior:

The Chrome browser performs as expected. With Firefox and Safari the installation process hangs after leaving the admin page and never returns.

If I refresh the Firefox/Safari page, the app admin iframe loads but the resulting text is the same, and the products do not load.

In all cases the app installs, but views/home/index.html.erb doesn't seem to load completely on Firefox & Safari.

Reproduces how often:

Every time

Browsers

Chrome (Version 100.0.4896.88 (Official Build) (x86_64)), Firefox (99.0.1 (64-bit)), Safari (Version 15.4 (15613.1.17.1.13, 15613)

Gem versions

Using ruby-3.1.2
Gems:
Rails 7.0.2.3
shopify_api (10.0.2)
shopify_app (19.0.1)
shopify-cli (2.15.6)

Additional Information

My naive troubleshooting seems to point to the Firefox & Safari browser installs stopping at line 13 in views/home/index.html.erb. In other words, I don't think the 'await import("lib/shopify_app")' is returning.

Security

  • I have redacted any private information from my logs or code snippets.
@fairknowe fairknowe added the bug label Apr 20, 2022
@fairknowe
Copy link
Author

I've added a repo with a Dockerfile and instructions that creates a simple app to illustrate this issue... https://github.com/fairknowe/Issue1417

@alfredoshopcreatify
Copy link

I'm seeing the same issue in Rails 7 with importmaps.

@nelsonwittwer
Copy link
Contributor

Thanks for reporting this! We recently merged in #1506 to address this issue with importmaps affecting Safari/Firefox. We are targeting a release at the end of the month, feel free to point at the main branch of this repo if you need a fix implemented sooner than that. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants