Generated App doesn't work in Safari/Firefox

[klenotiw]

What this PR does

The index.html.erb had a messed up import. The root of the problem seems to still be a mystery, but there is a problem with how shims work in Rails 7. I found that if I remove the event listener and use import, instead of import() then everything seems to work.

Q: Why do we need to remove the event listener?
The only real answer I have is that the event is already gone after the shim gets loaded. I figured this out with console logs but forgot to screenshot it. If this seems weird and you want me to get another screenshot I can.

closes Embedded apps not working on some browsers

Reviewer's guide to testing

Honestly the best way to test this is create an app in rails 6 and 7. If you have a previous app I think you should be able to use rails generate shopify_app on this branch, and your index.html.erb file should change slightly.

Things to focus on

1. Is it ok to use two separate templates?
2. Is there anything to be concerned about by removing the event listener
3. Is there anything to be concerned about by using import instead of import()

Checklist

Before submitting the PR, please consider if any of the following are needed:

• Update CHANGELOG.md if the changes would impact users
• Update README.md, if appropriate.
• Update any relevant pages in /docs, if necessary
• For security fixes, the Disclosure Policy must be followed.

[nelsonwittwer]

Thanks for tracking this down and getting this fix in!

[paulomarg]

Just a nit

[paulomarg]

Can we simplify this?

Suggested change

	document.addEventListener("DOMContentLoaded", async function() {
	displayProducts();
	});
	document.addEventListener("DOMContentLoaded", displayProducts);

[klenotiw]

You are right! I was trying to do this but I was using displayProducts() instead of displayProducts lesson learn lol. Thanks for this!