Set special redirection headers on 401s #1450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulomarg
force-pushed
the
set_redirection_headers
branch
from
9fa2e6f
to
0d6aa74
Compare
paulomarg
force-pushed
the
set_redirection_headers
branch
from
0d6aa74
to
eb4ad93
Compare
mkevinosullivan
approved these changes
Jun 14, 2022
|
Where is the accompanying client code which recognizes and acts on the special header? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
To make it easier for embedded apps to redirect to OAuth after a token expires and a request reaches the server, we set the special
X-Shopify-API-Request-Failure-Reauthorize-Urlheader, so that the client can know when to trigger an App Bridge redirect to the login action.Reviewer's guide to testing
This was mostly tested via unit tests, and on a new app.
Checklist
Before submitting the PR, please consider if any of the following are needed:
CHANGELOG.mdif the changes would impact users