Content Security Policy docs and better default #1504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nelsonwittwer
force-pushed
the
nelsonwittwer/csp_host
branch
from
fe62faf
to
ceb66fa
Compare
nelsonwittwer
changed the title
ENV["HOST"] in Content Security Policy
nelsonwittwer
changed the title
paulomarg
approved these changes
Sep 13, 2022
fabriazza
pushed a commit
to fabriazza/shopify_app
that referenced
this pull request
Feb 1, 2023
* allow ENV["HOST"] in CSP * remove test * docs for ENV["HOST"] CSP support * No more ENV, use configuration default instead * remove redundant changelog * remove current_shopify_domain support for CSP * current_shopify_domain or myshopify_domain from config * try without current_shopify_domain * allow current_shopify_domain and myshopify_domain * use singleton config for myshopify_domain * Add link to CSP docs * rubocop linter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
When setting the default host in the content security policy, use the application's configuration instead of a hard coded value.
Checklist
Before submitting the PR, please consider if any of the following are needed:
CHANGELOG.mdif the changes would impact usersREADME.md, if appropriate./docs, if necessary