Fix user session storing without scopes #1516
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
We had updated the
UserSessionStorageWithScopes
class to fix an issue where the type of theuser
param was incorrect, but the same issue was present inUserSessionStorage
. This PR fixes that to properly calluser.id
to access theAssociatedUser
property.Reviewer's guide to testing
You'll need to create an app with a few conditions:
rails g shopify_app:user_model
)n
when prompted if you want to add user scopesUser
model is using theinclude ShopifyApp::UserSessionStorage
concern (notShopifyApp::UserSessionStorageWithScopes
config.reauth_on_access_scope_changes = false
in theshopify_app
initializerconfig.user_session_repository = "User"
Things to focus on
Before this branch, that would lead into an infinite auth loop. With this fix, the app should authenticate normally, and there should be an entry in both the
users
andshops
tables.Checklist
Before submitting the PR, please consider if any of the following are needed:
CHANGELOG.md
if the changes would impact users