Renaming some Controller Concerns #1565
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…shopify_app into klenotiw/add-log-levels
andyw8
reviewed
Nov 4, 2022
lib/shopify_app/utils.rb
Outdated
| end | ||
|
|
||
| def self.deprecated(message) | ||
| send_to_logger(:warn, "DEPRECATED - #{message}") |
There was a problem hiding this comment.
I think we should be using the ActiveSupport Deprecation API for this:
https://andycroll.com/ruby/use-a-deprecation-message/
Co-authored-by: Andy Waite <13400+andyw8@users.noreply.github.com>
Co-authored-by: Andy Waite <13400+andyw8@users.noreply.github.com>
…shopify_app into klenotiw/add-log-levels
Co-authored-by: Andy Waite <13400+andyw8@users.noreply.github.com>
Co-authored-by: Andy Waite <13400+andyw8@users.noreply.github.com>
…shopify_app into klenotiw/add-log-levels
… of the functionality
andyw8
reviewed
Nov 11, 2022
| before_action :login_again_if_different_user_or_shop | ||
| around_action :activate_shopify_session | ||
| after_action :add_top_level_redirection_headers | ||
| ShopifyApp::Logger.deprecated("Authenticated has been renamed to EnsureHasSession") |
There was a problem hiding this comment.
Suggested change
| ShopifyApp::Logger.deprecated("Authenticated has been renamed to EnsureHasSession") | |
| ShopifyApp::Logger.deprecated("Authenticated has been renamed to EnsureHasSession") |
I would say 'replaced by' rather than renamed to here, since if someone is upgrading from an older version then there may also be behavior changes.
|
this pr will take over #1581 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
We had two controllers concerns that we wanted to rename, but still have our old names be backwards compatible for the time being.
RequireKnownShop => EnsureInstalled
Authenticated => EnsureHasSession
I merged in the commit from the logging PR because I wanted to add some deprecation logs. So sorry for the messed up commit history.
closes #1502
Reviewer's guide to testing
Things to focus on
Checklist
Before submitting the PR, please consider if any of the following are needed:
CHANGELOG.mdif the changes would impact usersREADME.md, if appropriate./docs, if necessary