Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renaming some Controller Concerns #1565

Closed
wants to merge 62 commits into from
Closed

Renaming some Controller Concerns #1565

wants to merge 62 commits into from

Commits on Oct 21, 2022

  1. first set of logs

    @klenotiw
    klenotiw committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    57fbed5 View commit details
    Browse the repository at this point in the history

  2. webhooks manager logs added

    @klenotiw
    klenotiw committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    d1d0a05 View commit details
    Browse the repository at this point in the history

  3. adding ShopifyApp before all errors

    @klenotiw
    klenotiw committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    d4d3946 View commit details
    Browse the repository at this point in the history

  4. missed these

    @klenotiw
    klenotiw committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    df4947b View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into klenotiw/add-log-levels

    @klenotiw
    klenotiw committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    f71f823 View commit details
    Browse the repository at this point in the history

  6. rubocop

    @klenotiw
    klenotiw committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    45ee7e9 View commit details
    Browse the repository at this point in the history

  7. getting this weird error from adding the logs

    @klenotiw
    klenotiw committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    3ae6a87 View commit details
    Browse the repository at this point in the history

  8. this was the line that was causing products not to load

    @klenotiw
    klenotiw committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    774dbb5 View commit details
    Browse the repository at this point in the history

  9. add more login protection logs

    @klenotiw
    klenotiw committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    1de873b View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2022

  1. change error msg

    @klenotiw
    klenotiw committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    69479ac View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2022

  1. add two logger functions to the utils module and add log levels to th… 

    …e configurations
    @klenotiw
    klenotiw committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    a305805 View commit details
    Browse the repository at this point in the history

  2. didn't mean to add this

    @klenotiw
    klenotiw committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    f84172c View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into klenotiw/add-log-levels

    @klenotiw
    klenotiw committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    5e38b94 View commit details
    Browse the repository at this point in the history

  4. add log for andy

    @klenotiw
    klenotiw committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    f4b8842 View commit details
    Browse the repository at this point in the history

  5. Use standard logger

    @andyw8
    andyw8 committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    69e0f04 View commit details
    Browse the repository at this point in the history

  6. changing rails logger to utils logger

    @klenotiw
    klenotiw committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    d5092db View commit details
    Browse the repository at this point in the history

  7. More logging

    @andyw8
    andyw8 committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    11049a0 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2022

  1. Merge branch 'klenotiw/add-log-levels' of https://github.com/Shopify/… 

    …shopify_app into klenotiw/add-log-levels
    @klenotiw
    klenotiw committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    5acf291 View commit details
    Browse the repository at this point in the history

  2. levels should layer

    @klenotiw
    klenotiw committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    29bd368 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2022

  1. add warn and error

    @klenotiw
    klenotiw committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    283e143 View commit details
    Browse the repository at this point in the history

  2. fix comparison

    @klenotiw
    klenotiw committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    bbd0efd View commit details
    Browse the repository at this point in the history

  3. default should be info

    @klenotiw
    klenotiw committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    3bd2e3d View commit details
    Browse the repository at this point in the history

  4. change and pull prefix out

    @klenotiw
    klenotiw committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    8b7b67b View commit details
    Browse the repository at this point in the history

  5. move everything over to new module

    @klenotiw
    klenotiw committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    36b3ed4 View commit details
    Browse the repository at this point in the history

  6. messed up syntax

    @klenotiw
    klenotiw committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    5a52b53 View commit details
    Browse the repository at this point in the history

  7. actually fix comparisions

    @klenotiw
    klenotiw committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    5886ca1 View commit details
    Browse the repository at this point in the history

  8. rubocop

    @klenotiw
    klenotiw committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    349adf6 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2022

  1. more logs and update old ones

    @klenotiw
    klenotiw committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    ad3b784 View commit details
    Browse the repository at this point in the history

  2. refactor logger

    @klenotiw
    klenotiw committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    6f704a3 View commit details
    Browse the repository at this point in the history

  3. add log and remove pry

    @klenotiw
    klenotiw committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    ae2bad1 View commit details
    Browse the repository at this point in the history

  4. session repository

    @klenotiw
    klenotiw committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    c4fee42 View commit details
    Browse the repository at this point in the history

  5. change any rails logs to our logger

    @klenotiw
    klenotiw committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    84c92fb View commit details
    Browse the repository at this point in the history

  6. rubocop

    @klenotiw
    klenotiw committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    1a072a9 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2022

  1. remove time and format log_level

    @klenotiw
    klenotiw committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    cc47406 View commit details
    Browse the repository at this point in the history

  2. rename two controller concern

    @klenotiw
    klenotiw committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    6222053 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/klenotiw/add-log-levels' into kl… 

    …enotiw/renaming-controller-concerns
    @klenotiw
    klenotiw committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    0d1c795 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2022

  1. add log levels to readme

    @klenotiw
    klenotiw committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    7235f2d View commit details
    Browse the repository at this point in the history

  2. add deprecation to logs

    @klenotiw
    klenotiw committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    2ead6bd View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2022

  1. Update README.md 

    Co-authored-by: Andy Waite <13400+andyw8@users.noreply.github.com>
    @klenotiw @andyw8
    klenotiw and andyw8 committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    09f4e92 View commit details
    Browse the repository at this point in the history

  2. Update docs/shopify_app/logging.md 

    Co-authored-by: Andy Waite <13400+andyw8@users.noreply.github.com>
    @klenotiw @andyw8
    klenotiw and andyw8 committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    02333fe View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2022

  1. move logger out of utils and into its own file

    @klenotiw
    klenotiw committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    5355a16 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'klenotiw/add-log-levels' of https://github.com/Shopify/… 

    …shopify_app into klenotiw/add-log-levels
    @klenotiw
    klenotiw committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    8670e87 View commit details
    Browse the repository at this point in the history

  3. fix log to be under if

    @klenotiw
    klenotiw committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    c5fec08 View commit details
    Browse the repository at this point in the history

  4. Update docs/shopify_app/logging.md 

    Co-authored-by: Andy Waite <13400+andyw8@users.noreply.github.com>
    @klenotiw @andyw8
    klenotiw and andyw8 committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    776a11f View commit details
    Browse the repository at this point in the history

  5. Update lib/generators/shopify_app/install/templates/shopify_app.rb.tt 

    Co-authored-by: Andy Waite <13400+andyw8@users.noreply.github.com>
    @klenotiw @andyw8
    klenotiw and andyw8 committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    3eb2eb4 View commit details
    Browse the repository at this point in the history

  6. change namespaces

    @klenotiw
    klenotiw committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    3a2fee7 View commit details
    Browse the repository at this point in the history

  7. handled errors will be under info

    @klenotiw
    klenotiw committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    07a703a View commit details
    Browse the repository at this point in the history

  8. pull out logic from logs and into a variable

    @klenotiw
    klenotiw committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    8661bbf View commit details
    Browse the repository at this point in the history

  9. require logger file

    @klenotiw
    klenotiw committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    55ad138 View commit details
    Browse the repository at this point in the history

  10. change some logs

    @klenotiw
    klenotiw committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    25bbb15 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2022

  1. Merge branch 'klenotiw/add-log-levels' of https://github.com/Shopify/… 

    …shopify_app into klenotiw/add-log-levels
    @klenotiw
    klenotiw committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    25d81cc View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into klenotiw/add-log-levels

    @klenotiw
    klenotiw committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    482751e View commit details
    Browse the repository at this point in the history

  3. fix dup message

    @klenotiw
    klenotiw committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    dccc327 View commit details
    Browse the repository at this point in the history

  4. fix enabled_for_log_level

    @klenotiw
    klenotiw committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    38d8a74 View commit details
    Browse the repository at this point in the history

  5. add configuration heading

    @klenotiw
    klenotiw committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    5fe3abd View commit details
    Browse the repository at this point in the history

  6. add logs to has payment conditionals

    @klenotiw
    klenotiw committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    003b38a View commit details
    Browse the repository at this point in the history

  7. change log

    @klenotiw
    klenotiw committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    68ee4f9 View commit details
    Browse the repository at this point in the history

  8. fix tests and lint

    @klenotiw
    klenotiw committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    ab72180 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'klenotiw/add-log-levels' into klenotiw/renaming-control… 

    …ler-concerns
    @klenotiw
    klenotiw committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    5fcaa00 View commit details
    Browse the repository at this point in the history

  10. use activesupport for deprecation

    @klenotiw
    klenotiw committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    268687a View commit details
    Browse the repository at this point in the history

  11. require_know_shop has methods so including/extending doesn't hold all… 

    … of the functionality
    @klenotiw
    klenotiw committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    d273e76 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2022

  1. fixing include issue

    @klenotiw
    klenotiw committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    728fbb7 View commit details
    Browse the repository at this point in the history