Add configuration option for user access scopes strategy #1599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyw8
changed the title
andyw8
commented
Nov 30, 2022
| test "user access scopes strategy is configurable" do | ||
| my_strategy = Object | ||
| ShopifyApp.configure do |config| | ||
| config.user_access_scopes_strategy = my_strategy |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Updated to use a string.
andyw8
force-pushed
the
andyw8/add-configuration-option-for-user-access-scopes-strategy
branch
from
d52ee48
to
af15eca
Compare
andyw8
commented
Nov 30, 2022
| @@ -83,7 +83,17 @@ def shop_access_scopes_strategy | |||
| ShopifyApp::AccessScopes::ShopStrategy | |||
| end | |||
|
|
|||
| def user_access_scopes_strategy=(class_name) | |||
| unless class_name.is_a?(String) | |||
There was a problem hiding this comment.
Using a string to be consistent with user_session_repository and shop_session_repository.
paulomarg
approved these changes
Nov 30, 2022
nelsonwittwer
approved these changes
Nov 30, 2022
andyw8
deleted the
andyw8/add-configuration-option-for-user-access-scopes-strategy
branch
4 tasks
fabriazza
pushed a commit
to fabriazza/shopify_app
that referenced
this pull request
Feb 1, 2023
Co-authored-by: Andy Waite <andyw8@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
The gem currently provides two strategies for verifying user scopes:
Some apps (likely only first party apps made by Shopify) may have special requirements and need to use a different strategy. This PR adds a configuration option to allow that.
Reviewer's guide to testing
Reach out to me on Slack to discuss.
Things to focus on
Checklist
Before submitting the PR, please consider if any of the following are needed:
CHANGELOG.mdif the changes would impact usersREADME.md, if appropriate./docs, if necessary