Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for metafield_namespaces in webhook registration #1745

Merged
merged 4 commits into from
Dec 15, 2023

Conversation

fourseven
Copy link
Contributor

@fourseven fourseven commented Nov 8, 2023

What this PR does

This is an extension on Shopify/shopify-api-ruby#1186, allowing users of the shopify_app ruby/rails library to register webhooks and expect them to return with metafields back.

Reviewer's guide to testing

I have updated the tests, as well as installing this into our codebase and testing that the app_uninstalled webhook fires, as well as an order create with metafields.

Things to focus on

  1. Nothing in particular, it's only a few lines changed
  2. Do you want the fixes to the tests? It was throwing an error expected positional hash (…), but received keyword arguments (…) for those two lines.

Checklist

Before submitting the PR, please consider if any of the following are needed:

  • Update CHANGELOG.md if the changes would impact users
  • Update README.md, if appropriate.
  • Update any relevant pages in /docs, if necessary
  • For security fixes, the Disclosure Policy must be followed.

@fourseven fourseven marked this pull request as ready for review November 8, 2023 22:23
@fourseven fourseven requested a review from a team as a code owner November 8, 2023 22:23
@fourseven
Copy link
Contributor Author

@nelsonwittwer could I get a review here please?

@schonert
Copy link

Nice @fourseven - This would be great! Let's get this shipped!

Copy link
Contributor

@lizkenyon lizkenyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@lizkenyon
Copy link
Contributor

I think this branch needs a rebase!

You will also need to update the changelog to match the current release. While you are updating that you could add a link to the Shopify.dev docs regarding subscribing to webhooks based on metafield namespaces.

@lizkenyon lizkenyon added the Waiting for Response Need more information before we can provide more assistance label Dec 12, 2023
This is an extension on Shopify/shopify-api-ruby#1186, allowing users of the shopify_app ruby/rails library to register webhooks and expect them to return with metafields back.
Fixes `expected positional hash (…), but received keyword arguments (…)` for those method calls by splatting them into keyword arguments.
@fourseven
Copy link
Contributor Author

Thanks @lizkenyon I've made those changes now.

@github-actions github-actions bot removed the Waiting for Response Need more information before we can provide more assistance label Dec 14, 2023
@lizkenyon lizkenyon merged commit b664bcf into Shopify:main Dec 15, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants