Properly handle 401 errors in XHR requests with LoginProtection #1787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After a 401 response from Shopify, we were simply attempting to redirect to Shopify, which wouldn't work for XHR requests for embedded apps. We can instead use redirect_to_login, which is aware of the context and will return the appropriate response in all cases.
paulomarg
force-pushed
the
catch_401_errors_in_login_protection
branch
from
95bfb63
to
5cb6dc0
Compare
paulomarg
changed the title
paulomarg
force-pushed
the
catch_401_errors_in_login_protection
branch
from
6e6e161
to
55b9ea5
Compare
matteodepalo
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Related to #1708
After a 401 response from Shopify, we were simply attempting to redirect to Shopify, which wouldn't work for XHR requests for embedded apps.
We can instead use redirect_to_login, which is aware of the context and will return the appropriate response in all cases.
Reviewer's guide to testing
You can reproduce the problem by:
Before, this would lead to an attempt at logging in within the iframe, which would fail.
Things to focus on
Is there any reason not to use the 401 response with headers at this point?
Checklist
Before submitting the PR, please consider if any of the following are needed:
CHANGELOG.mdif the changes would impact users