Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly handle 401 errors in XHR requests with LoginProtection #1787

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Properly handle 401 errors in XHR requests with LoginProtection #1787

merged 2 commits into from
Feb 9, 2024

Commits on Feb 8, 2024

  1. Use a 401 with headers for login redirect 

    After a 401 response from Shopify, we were simply attempting to redirect
to Shopify, which wouldn't work for XHR requests for embedded apps.

We can instead use redirect_to_login, which is aware of the context and
will return the appropriate response in all cases.
    @paulomarg
    paulomarg committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    5cb6dc0 View commit details
    Browse the repository at this point in the history

  2. Adding tests for new 401 handling

    @paulomarg
    paulomarg committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    55b9ea5 View commit details
    Browse the repository at this point in the history