Securely compare webhook hmac #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def hmac_valid?(data) | ||
| secret = ShopifyApp.configuration.secret | ||
| digest = OpenSSL::Digest.new('sha256') | ||
| ActiveSupport::SecurityUtils.secure_compare( |
There was a problem hiding this comment.
Can you consider using variable_size_secure_compare ?
|
one comment otherwise LGTM |
|
lgtm! |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
WebhookControllerso we useActiveSupport::SecurityUtils.secure_compareto compare webhook data with the actual HMAC. This improves our ability to handle timing attacks.@kevinhughes27 @djoume Please review.