Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v8.2.0 #451

Merged
merged 3 commits into from
Jan 5, 2021
Merged

Release v8.2.0 #451

merged 3 commits into from
Jan 5, 2021

Conversation

mllemango
Copy link
Contributor

WHY are these changes introduced?

Releasing 8.2.0 with changelog update

WHAT is this pull request doing?

Checklist

  • I have updated the CHANGELOG (if applicable)
  • I have followed the Shopify Python guide

Copy link
Contributor

@paulomarg paulomarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than the link thing.

CHANGELOG Outdated
@@ -1,3 +1,6 @@
== Version 8.2.0
- [Feature] Add support for Dynamic API Versioning (#441)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make the PR a link? Makes it easier to drill into changes later.

CHANGELOG Outdated
@@ -1,3 +1,6 @@
== Version 8.2.0
- [Feature] Add support for Dynamic API Versioning ([#441](https://github.com/Shopify/shopify_python_api/pull/441))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be worth expanding this, e.g.:

Add support for Dynamic API Versioning. When the library is initialized, it will now make a request to Shopify to fetch a list of the available API versions.

(this may be useful information to know if someone is using VCR.py or similar in their test suite).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see! That makes sense!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants