This repository has been archived by the owner on Apr 27, 2021. It is now read-only.
Bugfix check api availability #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should help to build something that will provide more information as to what is going wrong with client configuration
| end | ||
|
|
||
| private | ||
| attr_reader :client |
There was a problem hiding this comment.
attr_reader is usually placed near the top of classes. It doesn't need to be after private .
There was a problem hiding this comment.
It's mostly just so I can make the method call instead of saying @ivar in my classes.
There was a problem hiding this comment.
Yup. But attr_reader is usually placed near the top of the class, and doesn't need to be located after private . I'd move it up.
csaunders
force-pushed
the
bugfix-check-api-availability
branch
2 times, most recently
from
e95ee60
to
47005f7
Compare
In order to provide more details to users and give better failure modes, we verify the validity of a configuration. If the configuration is not valid we let the user know and reference them to the shopify_theme configuration page. We also check to see if the API is down, and if it is, let the user know and reference them to the shopify status page.
csaunders
force-pushed
the
bugfix-check-api-availability
branch
from
47005f7
to
ee60e6e
Compare
csaunders
added a commit
that referenced
this pull request
Sep 1, 2015
Bugfix check api availability
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to make the tool more user friendly this causes pre-emptive API checks to ensure that the API is accessible and the configuration is setup correctly.
When the configuration is not valid, the user will be presented with a screen that helps them debug what could be going wrong. This relies on their
storebeing correct, but if it isn't should look wrong and might help them debug it more easily.Note: I've bumped the version because I plan on releasing a new gem since this will help reduce duplicate bug reports.
Fixes #160 #146
Please review @nickhoffman @ilikeorangutans
/cc @stevebosworth @cshold @mpiotrowicz