Refactor module and test suite #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactor write method into three different methods with a single responsibility. - Allow StatsD instrumentation to be removed. - No more leaky tests, by removing instrumentation and proper stubbing
|
Nice refactor. LGTM 🚢 |
wvanbergen
added a commit
that referenced
this pull request
Jan 3, 2014
Refactor module and test suite
|
Failing test is a rubygems issue on 1.8.7, and will be fixed in the next rubygems release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into some issues with the test suite when I was trying to work on new features. So I decided to do a refactor first
writemethod into three different methods with a single responsibility.Should be 100% backwards compatible (TM).
@jstorimer @csfrancis