Refactor module and test suite #31

Merged
merged 4 commits into from Jan 3, 2014

2 participants

@wvanbergen
Shopify member

I ran into some issues with the test suite when I was trying to work on new features. So I decided to do a refactor first

  • Refactor write method into three different methods with a single responsibility.
  • Allow StatsD instrumentation to be removed.
  • Split tests into basic statsd client tests, and instrumentation tests.
  • No more leaky tests, by removing instrumentation and proper stubbing
  • Added a live test that actually tests sending a UDP packet locally.
  • Increased test coverage here and there.

Should be 100% backwards compatible (TM).

@jstorimer @csfrancis

wvanbergen added some commits Dec 27, 2013
@wvanbergen wvanbergen Use test helper. a042f91
@wvanbergen wvanbergen Remove monkey patching of Banchmark module. e0efcb6
@wvanbergen wvanbergen Refactor library and test suite.
- Refactor write method into three different methods with a single responsibility.
- Allow StatsD instrumentation to be removed.
- No more leaky tests, by removing instrumentation and proper stubbing
602e071
@wvanbergen wvanbergen Simplify live tests by removing Thread 6ac9442
@jstorimer

Nice refactor. LGTM 🚢

@wvanbergen wvanbergen merged commit 1745db6 into master Jan 3, 2014

1 check passed

Details default The Travis CI build passed
@wvanbergen wvanbergen deleted the refactor branch Jan 3, 2014
@wvanbergen
Shopify member

Failing test is a rubygems issue on 1.8.7, and will be fixed in the next rubygems release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment