Add compiler for ActiveRecord delegated types

[fcheung]

Motivation

ActiveRecord's delegated types feature adds a number of methods to active record models that were not included in the rbis generated by tapioca (See also #1240)

Implementation

Unlike associations, scopes etc. activerecord does not keep any internal metadata about which delegated types have been declared. I added an extension that records the parameters that delegated_type was called with so that this data can later be accessed from the compiler

Tests

Tests added to spec/tapioca/dsl/compilers/active_record_delegated_types_spec.rb

[fcheung]

Any more feedback @KaanOzkan ?

[KaanOzkan]

It LGTM but I'd like another review from someone with experience on delegated types.

Also can we fix the linting error? You can rebase to fix rest of the CI.

[fcheung]

Thanks - I have fixed that white space error and rebased

[rafaelfranca]

String isn't the return type of role_name. It is a ActiveSupport::StringInquirer.

[fcheung]

👍

[rafaelfranca]

Ins't build_#{role} already added by the belongs_to DSL generator?

tapioca/lib/tapioca/dsl/compilers/active_record_associations.rb

Line 205 in 4dd259f

"build_#{association_name}",

[fcheung]

I don’t think so because the belongs_to is polymorphic

[fcheung]

Could you have another look @rafaelfranca ?

[fcheung]

Those ci failures against 6.1 are odd :

it compiles constants of generic types ERROR (0.04s)
Minitest::UnexpectedError: TypeError: T.let: Expected type GenericInterface[::Numeric], got type Concrete with hash 24942688895262217
Caller: /tmp/d20221111-6657-m3v2y/lib/generic.rb:16
/tmp/d20221111-6657-m3v2y/lib/generic.rb:16:in <top (required)>' /home/runner/work/tapioca/tapioca/lib/tapioca.rb:23:in block in silence_warnings'
/opt/hostedtoolcache/Ruby/2.7.6/x64/lib/ruby/2.7.0/rubygems/user_interaction.rb:47:in use_ui' /home/runner/work/tapioca/tapioca/lib/tapioca.rb:22:in silence_warnings'
/home/runner/work/tapioca/tapioca/spec/tapioca/gem/pipeline_spec.rb:3328:in `block (2 levels) in class:PipelineSpec'

doesn't seem related to my changes. It also fails on master for me when I run that test file on its own

[st0012]

Hey @fcheung, the build has been fixed and once you rebased main it should run green.

[fcheung]

Thanks @st0012 - I have rebased

[fcheung]

This is also looking like an unrelated failure

cli
  gem
    generate
      it must generate RBIs for gems whose folder location starts with the same prefix as project folder PASS (1.85s)
      it uses ignores `abort` and `exit` calls inside autoloaded files PASS (11.87s)
      it must not generate RBIs for missing gem specs                 FAIL (2.58s)
        ########## STDOUT ##########
        <empty>
        ########## STDERR ##########
        bundler: failed to load command: tapioca (/opt/hostedtoolcache/Ruby/3.1.2/x64/lib/ruby/gems/3.1.0/bin/tapioca)
        /opt/hostedtoolcache/Ruby/3.1.2/x64/lib/ruby/3.1.0/rubygems/specification.rb:2111:in `method_missing': undefined method `identifier' for #<Gem::Specification:0x00007fb486753950 @extension_dir=nil, @full_gem_path=nil, @gem_dir=nil, @ignored=nil, @bin_dir=nil, @cache_dir=nil, @cache_file=nil, @doc_dir=nil, @ri_dir=nil, @spec_dir=nil, @spec_file=nil, @gems_dir=nil, @base_dir=nil, @loaded=false, @activated=false, @loaded_from="/opt/hostedtoolcache/Ruby/3.1.2/x64/lib/ruby/gems/3.1.0/specifications/parser-3.1.2.1.gemspec", @original_platform=nil, @installed_by_version=#<Gem::Version "3.3.7">, @autorequire=nil, @date=2022-08-08 00:00:00 UTC, @description="A Ruby parser written in pure Ruby.", @email=["whitequark@whitequark.org"], @homepage="https://github.com/whitequark/parser", @name="parser", @post_install_message=nil, @signing_key=nil, @summary="A Ruby parser written in pure Ruby.", @version=#<Gem::Version "3.1.2.1">, @authors=["whitequark"], @bindir="bin", @cert_chain=[], @dependencies=[<Gem::Dependency type=:runtime name="ast" requirements="~> 2.4.1">, <Gem::Dependency type=:development name="bundler" requirements=">= 1.15, < 3.0.0">, <Gem::Dependency type=:development name="rake" requirements="~> 13.0.1">, <Gem::Dependency type=:development name="racc" requirements="= 1.4.15">, <Gem::Dependency type=:development name="cliver" requirements="~> 0.3.2">, <Gem::Dependency type=:development name="yard" requirements=">= 0">, <Gem::Dependency type=:development name="kramdown" requirements=">= 0">, <Gem::Dependency type=:development name="minitest" requirements="~> 5.10">, <Gem::Dependency type=:development name="simplecov" requirements="~> 0.15.1">, <Gem::Dependency type=:development name="gauntlet" requirements=">= 0">], @executables=["ruby-parse", "ruby-rewrite"], @extensions=[], @extra_rdoc_files=[], @files=["bin/ruby-parse", "bin/ruby-rewrite"], @licenses=["MIT"], @metadata={"bug_tracker_uri"=>"https://github.com/whitequark/parser/issues", "changelog_uri"=>"https://github.com/whitequark/parser/blob/v3.1.2.1/CHANGELOG.md", "documentation_uri"=>"https://www.rubydoc.info/gems/parser/3.1.2.1", "source_code_uri"=>"https://github.com/whitequark/parser/tree/v3.1.2.1"}, @platform="ruby", @rdoc_options=[], @require_paths=["lib"], @required_ruby_version=#<Gem::Requirement:0x00007fb486750b10 @requirements=[[">=", #<Gem::Version "2.0.0">]]>, @required_rubygems_version=#<Gem::Requirement:0x00007fb4867519c0 @requirements=[[">=", #<Gem::Version "0">]]>, @requirements=[], @rubygems_version="3.3.7", @specification_version=4, @test_files=[], @new_platform="ruby", @full_name="parser-3.1.2.1", @source=#<Bundler::Source::Rubygems:0x32260 locally installed gems> parser-3.1.2.1> (NoMethodError)

[bdewater-thatch]

I checked out this branch on our app, the types look correct and srb tc still passes afterwards 🎉

[paracycle]

Thanks for the PR, this looks great!

[paracycle]

I think we don't strictly need either of these describe blocks, since they don't seem to be used in any of the test cases below. I know this PR has been open for a long time, so I'm more than happy to refactor this after a merge.