Skip dependabot PRs #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmneri-shopify
approved these changes
Mar 29, 2023
|
Okay, going to merge 🤞 |
|
Okay! That succeeded: I'm going to call this a win 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependabot PRs have always caused a promise rejection from the GitHub API due to permission issues. However, those rejections have been silently ignored until we upgraded to node 16, when they started failing. We reverted the upgrade in #10 to unblock teams using the tool.
This PR adds logic to skip processing PRs from Dependabot. It also re-applies the node 16 upgrade.
Once merged, I have a previous Dependabot run that succeeded because of node silently accepting the rejected promise. I will re-run it (from same execution context, eg the actor is still Dependabot) and it should continue to succeed and log the skip.