Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate support for API endpoint artifact retrieval #10

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

lfroms
Copy link
Member

@lfroms lfroms commented Aug 26, 2024

What does this change accomplish?

Using an API endpoint on a remote server can be handy, but it does require an organization to potentially need to lower their security standards on the web service that hosts these endpoints to just basic HTTP authentication. This change deprecates and removes the ability to retrieve artifacts this way in favour of the classic URL method which doesn't require additional APIs to be exposed on potentially sensitive services.

How have you achieved it?

By deleting all API endpoint based artifact retrieval.

How can the change be tested?

  1. Build and run Tophat.
  2. Ensure there that the API endpoint based retrieval is gone from the app.

@lfroms lfroms self-assigned this Aug 26, 2024
Copy link

@gvarandas gvarandas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM ✅.
Also checked the existing docs for any leftover references to the remote API support but couldn't find any 👍

@lfroms lfroms merged commit 2a3d302 into main Aug 26, 2024
3 checks passed
@lfroms lfroms deleted the deprecate-api-endpoints branch August 26, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants