added verbose error on proxy upstream dialing #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
@f-dg Thank you for your contribution. Can you please sign CLA and update CHANGELOG.md? CLA check: https://github.com/Shopify/toxiproxy/pull/355/checks?check_run_id=4781611074 |
|
@miry Done |
miry
reviewed
Jan 11, 2022
CHANGELOG.md
Outdated
| @@ -3,6 +3,7 @@ | |||
| * Verify git tag on release (#347, @miry) | |||
| * Fix MacOS 12 tests for go17 with -race flag (#351, @strech) | |||
| * Rename `testing/` and `bin/` folders (#354, @strech) | |||
| * Added verbose error on proxy upstream dialing | |||
There was a problem hiding this comment.
Don't forget to mention issue and yourself.
* Added verbose error on proxy upstream dialing (#355, @f-dg)
miry
approved these changes
Jan 12, 2022
|
@f-dg ❤️ |
|
@f-dg Changes have been released as part of https://github.com/Shopify/toxiproxy/releases/tag/v2.4.0. Thanks for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added more verbosity when an error happens during dialing an upstream.
It helped me to find out a reason about what errors were when trying to connect.