Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add requireLogin for customer account order status api #1673

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

brianshen1990
Copy link
Contributor

@brianshen1990 brianshen1990 commented Jan 22, 2024

Background

Part of https://github.com/Shopify/core-issues/issues/65428

Add requireLogin for customer account order status api

customer account web side PR: https://github.com/Shopify/customer-account-web/pull/3779

🎩

Please see tophat in this PR: customer account web side PR: https://github.com/Shopify/customer-account-web/pull/3779

Checklist

  • I have 🎩'd these changes
  • I have updated relevant documentation

@brianshen1990 brianshen1990 changed the title login and back add requireLogin for customer account order status api Jan 23, 2024
@brianshen1990 brianshen1990 self-assigned this Jan 24, 2024
@brianshen1990 brianshen1990 marked this pull request as ready for review January 24, 2024 15:38
Copy link
Contributor

@lihaokx lihaokx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brianshen1990 brianshen1990 merged commit e13098d into unstable Jan 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants