Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wishlist for the speed.yjit.org front page #255

Closed
9 tasks done
maximecb opened this issue May 17, 2024 · 0 comments
Closed
9 tasks done

Wishlist for the speed.yjit.org front page #255

maximecb opened this issue May 17, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@maximecb
Copy link
Contributor

maximecb commented May 17, 2024

Motivation: the speed.yjit.org page is a useful summary of the progress our team is making. It's useful both internally and externally. I look at it all the time to get a quick idea of the progress we're making. I think it's very valuable to optimize the information we display on that page to maximize usefulness, and focus our attention on the metrics we care about the most.

  • Bars comparing YJIT 3.3 vs 3.4dev
  • Remove the bar for the interpreter, replace it with a horizontal line at 1.0
  • Baseline currently says "no jit", should be more specificic, eg "CRuby 3.3"
  • Add bars at the right for the geometric mean (geomean) of CRuby 3.4, YJIT 3.3 and YJIT 3.4
  • Create a normalized memory usage graph with a similar format to the speedup graph, also to be included on the front page
    • This will be very valuable because it's a big blind spot for us right now. We don't pay much attention
      to how memory usage changes over time, and can get blindsided by regressions.
    • Possibly, we should measure this for the 3.4 interpreter as well? It would be good to be able to detect
      regressions there, and know what is or is not due to YJIT.
    • This should also have geomean columns as well
    • Ideally, this should be measured using "max RSS", which yjit-bench is able to track (feel free to copy the code).
    • Add graphs for memory usage comparison #267

Lower priority:

  • Tweak colors, styling, current theme not aesthetically pleasing
  • We currently show the speedup value when hovering, if there was a way to write this value inside the bars (or at the top at an angle) in a small font, it might be better?
  • Nitpick: we show the time with seconds at the top of the page, but the seconds aren't useful.

Note:

  • if we end up with 3 bars for the memory graph (3.4 interp, 3.3 YJIT, 3.4 YJIT), then maybe we also want to have the same 3 bars for the speedup graph, for consistency. This would also give us some visibility into interpreter performance improvements and regressions.

@rwstauner I ended up writing lots of notes. Hope this is helpful :)

@maximecb maximecb added the enhancement New feature or request label May 17, 2024
@rwstauner rwstauner self-assigned this May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants