Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label bars with their values #269

Merged
merged 3 commits into from
Jun 19, 2024
Merged

Label bars with their values #269

merged 3 commits into from
Jun 19, 2024

Conversation

rwstauner
Copy link
Contributor

There are several ways to do this, but none that are perfect:

  • I tried it at the bottom on the bar, which was ok (if you don't mind fully vertical), but when the bar is short it falls off
    image
  • We could add another row below the axis but I haven't seen any other graphs do that before

Then I tried it at the top of the bar with a semi-transparent background and found them to be surprisingly legible... they overlap the next bar ever so slightly and yet you can still see the edge of the bar and the variance whiskers. Even when they overlap each other I can discern which is which.

What do you think?

image

image

Copy link
Member

@k0kubun k0kubun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems okay, but I would maybe make the labels just a little bit smaller to avoid overlaps?

There is still a small amount of overlap but much less than before.
@rwstauner
Copy link
Contributor Author

I shrunk the text a bit and moved the labels to be more centered over the bar.
What do you think?

image
image
image

It also doesn't look terrible completely vertical (-90 transform) but still the text can overlap when there are too many bars

@maximecb maximecb merged commit 9639266 into main Jun 19, 2024
1 check passed
@maximecb maximecb deleted the rwstauner/bar-values branch June 19, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants