Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move "theme" attributes to a root level yaml file and update some styles #264

Merged
merged 9 commits into from
May 30, 2024
Merged

Move "theme" attributes to a root level yaml file and update some styles #264

merged 9 commits into from
May 30, 2024

Conversation

rwstauner
Copy link
Contributor

@rwstauner rwstauner commented May 29, 2024 •
edited
Loading

  • Move bar chart svg colors to theme yaml file
  • Change bar chart colors to use IBM color palette
  • Fix legend box text alignment
  • Move legend box stroke color to theme.yaml
  • Remove legend box border for consistency with bars
  • Make stddev markers less obtrusive
  • Add shadow to legend text to help with contrast
  • Make bar chart background color white

What do you think?
image

@rwstauner rwstauner mentioned this pull request May 29, 2024
Closed
9 tasks
@rwstauner rwstauner merged commit 5b7971c into main May 30, 2024
1 check passed
@rwstauner rwstauner deleted the rwstauner/theme branch May 30, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k0kubun k0kubun k0kubun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rwstauner @k0kubun