Get ruby version for graph label from metadata #253
Conversation
so that it is always accurate
| ["MJIT3.0", @with_mjit30_config], | ||
| ["MJIT", @with_mjit_latest_config], |
There was a problem hiding this comment.
Probably not, if we don't care about showing them for past reports.
Currently old reports and data are cached on the server.
If we ever wanted to rebuild past reports for old data files (that had MJIT data), keeping these means they'll be included on the graphs.
If that's not important (and we just wanted old graphs to show whatever configs we still care about now) we could get rid of these (in which case I'd make a new github issue to clean up these references).
What do you think?
There was a problem hiding this comment.
We generally bisect commits after the last release (to find a regression point in an under-development version), so it seems fine to have graphs only for dates without MJIT. It should at least cover the past one year.
Having said that, since this only helps maintainability, it seems fine to leave it for now if it's hard to clean them up.
This way the version is accurate next year, and also if we regenerate old reports.
This implementation uses a placeholder to specify where we want the version (which means labels have to opt in)... We could just append it to all if we want, for example
No JIT 3.4.0dev.before
after