Added FileLogger and added Unit tests #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szeber
approved these changes
Mar 23, 2017
composer.json
Outdated
| @@ -14,7 +14,8 @@ | |||
| "require-dev": { | |||
| "aws/aws-sdk-php": "^3.18", | |||
| "phpunit/phpunit": "^5.7", | |||
There was a problem hiding this comment.
We should consider upgrading phpunit to 6 as well
| /** | ||
| * Base test class for the unit tests of the DbHelperAbstract. | ||
| */ | ||
| abstract class DbHelperAbstractTestAbstract extends TestAbstract |
There was a problem hiding this comment.
That's a mouthfull of a name...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to change a few things because of the strict types and in the meanwhile I had to debug quite a lot. Therefore I decided to introduce a few unit tests to save some time.
What's important is that we should really add the helpers to the DI in the yapep sooner or later to be able to mock them out easily.