forked from AndrewHartAR/ARKit-CoreLocation
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Master #1
Open
johnrechd
wants to merge
227
commits into
Shotzoom:swift5Merge
Choose a base branch
from
AndrewHartAR:master
base: swift5Merge
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Master #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With ARKit 1.5 introduced in iOS 11.3 a new case was added to the enumeration ARCamera.TrackingState.Reason called .relocalizing. This new case not present in the switch statement causes the project to fail during building.
Added .DS_Store to gitignore & added newline to end of file.
Fix a switch statement not being exhaustive after ARKit 1.5 update
And rebuilds `sceneContainsNodeWithTag` on the `findNodes` method
Add a tag to LocationNode base class and ability to find nodes w/specific tags in a scene
adding swift markdown syntax
added japanese readme
...and Cocoapods materials. If we were using Cocoapods for more than logging in the demo app I might think differently about this, but it and Cocoa Lumberjack are an overly heavyweight solution for a dozen logging statements for a demo.
Remove Cocoa Lumberjack
Update Podspec to version 1.0.3
Adds a very basic set of Swiftlint rules, and makes sure that the project and demo app follow them. More details on Swiftlint are available at https://github.com/realm/SwiftLint
Adds Swiftlint support
* Move project source into a framework target * Share the framework target so that Carthage can build it * Update Podspec to point to the new source location * Change access levels of a handful of types, properties, and methods to make sure the project works successfully as a framework * Modify the demo app to import the new framework
Adds support for Carthage
Fixes path issue in podspec
Added method to remove all nodes on the scene
Give callers from outside of the module readonly access to the `SceneLocationView`'s `locationNodes`.
Allows readonly access to the SceneLocationView's nodes
calculating metersToLongitude is wrong because it depends on latitude!
* Fix Swiftlint violations * Add a couple simple tests
Improves coordinateWithBearing
Fix Memory Leak
… xcconfig setting instead.
CALayer node with dynamic time stamp
Clean up noise in Cocoapods setup. Update Pods.xcodeproj to recommended settings.
This reverts commit daefdad.
…lose but not perfect) constant
A few more geodesy tests and comments
Fix minor error with placement of route steps
Bump version number to 1.3.0 in ARCL-Info.plist and changelog
Updated ARCL version to 1.3.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating for swift 5 compatibility.