Do not reset ftplugin when no filetype has specified #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First of all, reseting ftplugin is only required when the current buffer has filetype. Reseting ftplugin cause incorrect autocmd order (FileType -> BufReadPost rather than BufReadPost -> FileType) and that cause unexpected behavior. See: Shougo/unite.vim#1137
|
I have fixed the behavior. Please test it. |
|
I tried with #44 and confirmed that the problem is fixed. Thanks :-) |
delphinus
pushed a commit
to delphinus/dein.vim
that referenced
this pull request
Apr 6, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, reseting ftplugin is only required when the current buffer has filetype.
Reseting ftplugin cause incorrect autocmd order (FileType -> BufReadPost rather than
BufReadPost -> FileType) and that cause unexpected behavior.
See: Shougo/unite.vim#1137
ftpluginのリセットにより autocmd の呼び出し順番が変わりftplugin/xxxxx.vimの適用が 初回だけ うまく行かないという現象を修正する PR です。ftpluginのリセットは&filetypeが存在しない場合には意味がないだろうという予想のもとこのような修正にしているので、これで問題が発生しないかは自信がありません。そのあたりを含めてレビューお願いいたします。