Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use paths that are more "environment-friendly" #329

Closed
wants to merge 3 commits into from
Closed

Use paths that are more "environment-friendly" #329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
39a89f4
change bin/bash to /usr/bin/bash
Aug 13, 2016
0282b16
change test to use /usr/bin instead of /usr/lib which may not exist o…
Aug 13, 2016
b859144
remove accidentally commited submodule
Aug 13, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion rplugin/python3/deoplete/tests/test_util.py
View file
Open in desktop
Expand Up @@ -20,4 +20,4 @@ def test_custom(self):
eq_(get_custom(custom, 'foo', 'converters', 'foobar'), 'foobar')

def test_globruntime(self):
eq_(globruntime('/usr', 'lib'), ['/usr/lib'])
eq_(globruntime('/usr', 'bin'), ['/usr/bin'])
2 changes: 1 addition & 1 deletion run_tests.sh
View file
Open in desktop
@@ -1,4 +1,4 @@
#!/bin/bash
#!/usr/bin/env bash
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you change it?
I don' think this change is needed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've run into cases where /bin/bash doesn't actually exist and /usr/bin/env bash was more reliable. I think it was on FreeBSD.

OTH, the contents of run_tests.sh could be placed in Makefile.


set -e

Expand Down