-
-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix swarm timeout between orborus and worker hosted on separate nodes #1146
Conversation
yet to be tested. let's wait before we proceed. |
Shuffle/Shuffle-docs#171 please close as you close this. |
my concerns i would want you to review start here: Shuffle/functions/onprem/orborus/orborus.go Line 227 in fddca01
my assumption is that in the container, the first network interface after loopback is the best way to spot the docker bridge network. this is an observation i made. i don't know when it would change. you will have to give some feedback on the consistency of this. i am also thinking of checking once if the network interface contains "eth0" since it does till a certain part. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Submit review!!
Would test this and make sure it's somewhat ready for prod. Be ready to see it break however. Quite unsure about the network interface naming however if chatGPT isn't hallucinating:
I referred to this pattern in the code. Will test it by tomorrow so you can put it to prod. https://medium.com/@diegogabrielschurch/how-docker-network-works-bridge-driver-e4819459cc8a this article does make me a little bit more clear. but i know we will break something :)
|
This definitely makes me feel more confident in nothing messing up. |
Ready for merge. Let's break things. |
ready |
Looks better! Covering all bases with a fallback |
https://github.com/orgs/Shuffle/projects/8/views/47