Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cross point switch HL for EOS and QMS card #190

Merged
merged 4 commits into from
Mar 16, 2023
Merged

Add cross point switch HL for EOS and QMS card #190

merged 4 commits into from
Mar 16, 2023

Conversation

matthias-schuessler
Copy link
Contributor

Adds a file XPT.py containing the HL for EOS and QMS card.

Also contains a change to Keithley2000 adding the option to set NPLC in DC voltage mode

@codecov
Copy link

codecov bot commented Jan 13, 2023

Codecov Report

Base: 35.90% // Head: 34.44% // Decreases project coverage by -1.46% ⚠️

Coverage data is based on head (fc6d226) compared to base (26fcc9f).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #190      +/-   ##
==========================================
- Coverage   35.90%   34.44%   -1.47%     
==========================================
  Files          79       80       +1     
  Lines        5284     5508     +224     
==========================================
  Hits         1897     1897              
- Misses       3387     3611     +224     
Impacted Files Coverage Δ
basil/HL/XPT.py 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@leloup314
Copy link
Member

Thanks for the contribution, looks good! Would be nice if you could add an example to the examples folder. If you don't find any of the existing folders fitting (e.g. lab_devices, etc) you can also add a new folder (e.g. EOS or serial_powering, etc). The example should consist of a config-yaml as well as a Python script showcasing the usage and basic functionality of the contents of the XPT.py HL.

@matthias-schuessler
Copy link
Contributor Author

I talked with Florian and Yannick about adding an example. We think that it doesn't make sense to add one, since our only application for the switches is the QMS-card, which needs bdaq to operate. Thus, an example wouldn't work in basil without adding the entire bdaq class.

@leloup314
Copy link
Member

Okay, then let me know once this is ready to be merged

@matthias-schuessler
Copy link
Contributor Author

From my end, this is ready to merge.

@leloup314 leloup314 merged commit 10f154e into master Mar 16, 2023
@leloup314 leloup314 deleted the qms_card branch March 16, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants