Add endpoint to prune metrics #806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisSchinnerl
force-pushed
the
chris/metrics-prune
branch
2 times, most recently
from
122af92
to
d886cb1
Compare
ChrisSchinnerl
force-pushed
the
chris/metrics-prune
branch
from
d886cb1
to
51cdbf1
Compare
ChrisSchinnerl
force-pushed
the
chris/metrics-prune
branch
2 times, most recently
from
126cc85
to
068d4d3
Compare
peterjan
approved these changes
Dec 11, 2023
peterjan
reviewed
Dec 11, 2023
| @@ -14,6 +14,7 @@ const ( | |||
| MetricContractSet = "contractset" | |||
| MetricContractSetChurn = "churn" | |||
| MetricContract = "contract" | |||
| MetricPerformance = "performance" | |||
There was a problem hiding this comment.
I think it's odd we have to add this metric here, and only use it in newly added code. There should be several places (switch cases) that we have to extend to add this missing metric. Edit: checked and there's indeed 3 instances where a performance is missing.
peterjan
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.