Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: walletd rescan #566

Merged
merged 1 commit into from Apr 15, 2024
Merged

feat: walletd rescan #566

merged 1 commit into from Apr 15, 2024

Conversation

alexfreska
Copy link
Member

@alexfreska alexfreska commented Mar 30, 2024

  • Address generation and addition dialogs now have an option to rescan from a specified height.
  • There is now a dedicated rescan dialog that can be opened from the wallet list and wallet context menus.
  • Rescan progress and status including errors is now shown in a sticky status bar.
Screenshot 2024-04-04 at 11 18 40 AM Screenshot 2024-04-04 at 10 51 46 AM Screenshot 2024-04-04 at 10 51 48 AM Screenshot 2024-04-04 at 10 20 27 AM

Copy link

changeset-bot bot commented Mar 30, 2024

🦋 Changeset detected

Latest commit: 6147c23

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
walletd Minor
@siafoundation/design-system Minor
@siafoundation/react-walletd Minor
@siafoundation/mock-walletd Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@n8maninger
Copy link
Member

I’m not sure we should enable this or maybe hide it behind an advanced flag. What do you think?

@alexfreska
Copy link
Member Author

I’m not sure we should enable this or maybe hide it behind an advanced flag. What do you think?

@n8maninger The toggle defaults to OFF and in this state it does not show the index input or the warning below.

Do you mean completely disable this feature by default via a daemon startup config value? Or do you mean just tucking it away a bit more than it is - maybe you have to expand the advanced section to even see the toggle?

@n8maninger
Copy link
Member

I don't know what would be best. My concern is that users will input a number in the index field without really understanding what it does and then be confused when their wallet doesn't show transactions. I meant tucking it away a bit more over a config flag or anything like that. It just needs to be very clear about the portion of blockchain that won't be scanned and the ramifications of that.

@alexfreska alexfreska changed the base branch from walletd_remove_deprecated to main April 1, 2024 15:23
@alexfreska alexfreska changed the title feat: walletd resubscribe feat: walletd rescan Apr 4, 2024
@alexfreska alexfreska force-pushed the feat_walletd_resubscribe branch 5 times, most recently from e17d92d to 86a50ff Compare April 4, 2024 17:06
@alexfreska alexfreska force-pushed the feat_walletd_resubscribe branch 2 times, most recently from 1fc2113 to 24e381e Compare April 10, 2024 08:18
@alexfreska alexfreska merged commit 23168c6 into main Apr 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants