Py3 - Finally

[miigotu]

Fixes #6545

In Progress:

• Fixing tests and providers, finding bugs

Done:

• Get running on python3
• Removed encode/decode trash
• Removed workarounds for windows for features added in python3 specifically for windows
• Removed SSL hacks
• Removed locale hacks
• Removed encoding Kluge hack
• Removed exception formatting hack
• Remove python2 support (supporting both will be a nightmare, maybe a backport will be possible)
• Handled trait API module
• jsonrpclib-pelix
• bencodepy
• Rework logger to use standardized logging
• remove old qbittorent and make new the default
• add new support for rtorrent and only support the new version
• refactor into sickchill from sickbeard module
• handle adba

To-Do:

• Check that python3 exists before allowing update in old mainline
• add new support for rtorrent and only support the new version
• remove old kodi, make kodi12+ default
• use logger args rather than .format

[codecov]

Codecov Report

Merging #6572 into develop will decrease coverage by 0.175%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           develop     #6572       +/-   ##
=============================================
- Coverage   31.531%   31.356%   -0.176%     
=============================================
  Files          236       231        -5     
  Lines        30709     30852      +143     
=============================================
- Hits          9683      9674        -9     
- Misses       21026     21178      +152     

Impacted Files	Coverage Δ
sickchill/views/manage/post_processing.py	46.153% <0.000%> (-3.847%)	⬇️
sickchill/show/indexers/wrappers.py	48.148% <0.000%> (-3.576%)	⬇️
sickchill/show/recommendations/favorites.py	46.428% <0.000%> (-3.572%)	⬇️
sickchill/helper/media_info.py	66.037% <0.000%> (-3.054%)	⬇️
sickchill/views/common.py	23.437% <0.000%> (-2.952%)	⬇️
sickchill/views/api/authentication.py	47.058% <0.000%> (-2.942%)	⬇️
sickchill/views/irc.py	70.000% <0.000%> (-2.728%)	⬇️
sickchill/views/config/backup.py	34.782% <0.000%> (-2.718%)	⬇️
sickchill/views/changelog.py	50.000% <0.000%> (-2.632%)	⬇️
sickchill/views/authentication.py	37.500% <0.000%> (-2.500%)	⬇️
... and 388 more

[lgtm-com]

This pull request introduces 30 alerts and fixes 136 when merging 5c9f452 into ed2b7bd - view on LGTM.com

new alerts:

• 20 for Module is imported with 'import' and 'import from'
• 3 for Unused local variable
• 3 for Except block handles 'BaseException'
• 1 for Unmatchable dollar in regular expression
• 1 for Non-callable called
• 1 for Variable defined multiple times
• 1 for __init__ method calls overridden method

fixed alerts:

• 86 for Module is imported with 'import' and 'import from'
• 20 for Unused import
• 6 for 'import *' may pollute namespace
• 4 for Unused local variable
• 2 for Comparison using is when operands support __eq__
• 2 for Except block handles 'BaseException'
• 2 for Missing call to __init__ during object initialization
• 2 for Explicit export is not defined
• 2 for __init__ method calls overridden method
• 1 for Unmatchable dollar in regular expression
• 1 for Unnecessary pass
• 1 for Testing equality to None
• 1 for Inconsistent equality and inequality
• 1 for Formatting string mixes implicitly and explicitly numbered fields
• 1 for Unused argument in a formatting call
• 1 for Unreachable code
• 1 for Variable defined multiple times
• 1 for Inconsistent equality and hashing
• 1 for Result of integer division may be truncated

[lgtm-com]

This pull request introduces 29 alerts and fixes 146 when merging a9f6460 into ed2b7bd - view on LGTM.com

new alerts:

• 20 for Module is imported with 'import' and 'import from'
• 3 for Unused local variable
• 2 for Except block handles 'BaseException'
• 1 for Unmatchable dollar in regular expression
• 1 for Non-callable called
• 1 for Variable defined multiple times
• 1 for __init__ method calls overridden method

fixed alerts:

• 86 for Module is imported with 'import' and 'import from'
• 20 for Unused import
• 12 for Except block handles 'BaseException'
• 6 for 'import *' may pollute namespace
• 4 for Unused local variable
• 2 for Comparison using is when operands support __eq__
• 2 for Missing call to __init__ during object initialization
• 2 for Explicit export is not defined
• 2 for __init__ method calls overridden method
• 1 for Unmatchable dollar in regular expression
• 1 for Unnecessary pass
• 1 for Testing equality to None
• 1 for Inconsistent equality and inequality
• 1 for Formatting string mixes implicitly and explicitly numbered fields
• 1 for Unused argument in a formatting call
• 1 for Unreachable code
• 1 for Variable defined multiple times
• 1 for Inconsistent equality and hashing
• 1 for Result of integer division may be truncated

[lgtm-com]

This pull request introduces 27 alerts and fixes 151 when merging 6a30c92 into ed2b7bd - view on LGTM.com

new alerts:

• 19 for Module is imported with 'import' and 'import from'
• 4 for Unused local variable
• 1 for Unmatchable dollar in regular expression
• 1 for Non-callable called
• 1 for Variable defined multiple times
• 1 for __init__ method calls overridden method

fixed alerts:

• 86 for Module is imported with 'import' and 'import from'
• 20 for Unused import
• 14 for Except block handles 'BaseException'
• 6 for 'import *' may pollute namespace
• 5 for Unused local variable
• 3 for Testing equality to None
• 2 for Comparison using is when operands support __eq__
• 2 for Missing call to __init__ during object initialization
• 2 for Explicit export is not defined
• 2 for __init__ method calls overridden method
• 1 for Unmatchable dollar in regular expression
• 1 for Unnecessary pass
• 1 for Inconsistent equality and inequality
• 1 for Formatting string mixes implicitly and explicitly numbered fields
• 1 for Unused argument in a formatting call
• 1 for Unreachable code
• 1 for Variable defined multiple times
• 1 for Inconsistent equality and hashing
• 1 for Result of integer division may be truncated