Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update method signatures for cast_ray and add assertions #36

Merged
merged 4 commits into from
Jan 26, 2022
Merged

update method signatures for cast_ray and add assertions #36

merged 4 commits into from
Jan 26, 2022

Conversation

Sid-Bhatia-0
Copy link
Owner

  1. Remove unnecessary type constraints in function method signatures of cast_ray. Those constraints were not used for dispatch. They did implicitly document some useful things though. But I will clarify the usage in the documentation.
  2. Add assertions for max_steps and tile_length to always be positive.
  3. Move i_ray_start_tile, j_ray_start_tile to the end of argument list.

@Sid-Bhatia-0 Sid-Bhatia-0 merged commit 6061670 into master Jan 26, 2022
@Sid-Bhatia-0 Sid-Bhatia-0 deleted the update_signatures branch January 26, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Sid-Bhatia-0