feat: track Eclipse state directly in Ovale #952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an `eclipse` module that tracks the player's Eclipse state as spells are cast by the player. The following script conditions are provided: * `EclipseAnyNext()`, `EclipseLunarNext()`, `EclipseSolarNext()` return true or false depending on which eclipse can be triggered next. * `EclipseLunarIn()` returns the number of Wrath casts needed to enter a lunar eclipse. * `EclipseSolarIn()` returns the number of Starfire casts needed to enter a solar eclipse.
Eclipse state is tracked by the `eclipse` module and obsoletes the previous counter code in the druid scripts.
|
This pullup with require the |
|
This pullup includes a commit to hand-modify the generated script for balance druid, so the scripts don't need to be regenerated for a new release until the new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Track Eclipse state directly in Ovale and avoid needing special
handling in scripts, including Eclipse buffs triggered by spell
casts.
This fixes ticket #794.