Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: track Eclipse state directly in Ovale #952

Merged
merged 4 commits into from
Aug 8, 2021

Commits on Aug 4, 2021

  1. feat: implement eclipse module to track druid's eclipse state

    Add an `eclipse` module that tracks the player's Eclipse state as
    spells are cast by the player. The following script conditions
    are provided:
    
    * `EclipseAnyNext()`, `EclipseLunarNext()`, `EclipseSolarNext()`
      return true or false depending on which eclipse can be
      triggered next.
    
    * `EclipseLunarIn()` returns the number of Wrath casts needed to
      enter a lunar eclipse.
    
    * `EclipseSolarIn()` returns the number of Starfire casts needed to
      enter a solar eclipse.
    johnnylam88 committed Aug 4, 2021
    Configuration menu
    Copy the full SHA
    f27eb50 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    96ca4cb View commit details
    Browse the repository at this point in the history
  3. fix: remove unnecessary counter properties from starfire and wrath

    Eclipse state is tracked by the `eclipse` module and obsoletes the
    previous counter code in the druid scripts.
    johnnylam88 committed Aug 4, 2021
    Configuration menu
    Copy the full SHA
    849b9f2 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    fc4da81 View commit details
    Browse the repository at this point in the history