Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: track Eclipse state directly in Ovale #952

Merged
merged 4 commits into from
Aug 8, 2021
Merged

feat: track Eclipse state directly in Ovale #952

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f27eb50
feat: implement eclipse module to track druid's eclipse state
johnnylam88 Aug 2, 2021
96ca4cb
fix: teach emitter to use the new druid eclipse conditions
johnnylam88 Aug 3, 2021
849b9f2
fix: remove unnecessary counter properties from starfire and wrath
johnnylam88 Aug 3, 2021
fc4da81
fix: hand-modify generated scripts to use the new eclipse conditions
johnnylam88 Aug 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/ioc.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import { DebugTools } from "./engine/debug";
import { OvaleDemonHunterDemonicClass } from "./states/DemonHunterDemonic";
import { OvaleDemonHunterSoulFragmentsClass } from "./states/DemonHunterSoulFragments";
import { OvaleSigilClass } from "./states/DemonHunterSigils";
import { Eclipse } from "./states/eclipse";
import { OvaleEnemiesClass } from "./states/Enemies";
import { OvaleEquipmentClass } from "./states/Equipment";
import { OvaleFrameModuleClass } from "./ui/Frame";
Expand Down Expand Up @@ -80,6 +81,7 @@ export class IoC {
public demonHunterDemonic: OvaleDemonHunterDemonicClass;
public demonHunterSigils: OvaleSigilClass;
public demonHunterSoulFragments: OvaleDemonHunterSoulFragmentsClass;
public eclipse: Eclipse;
public enemies: OvaleEnemiesClass;
public equipment: OvaleEquipmentClass;
public frame: OvaleFrameModuleClass;
Expand Down Expand Up @@ -194,6 +196,14 @@ export class IoC {
this.spellBook,
this.power
);
this.eclipse = new Eclipse(
this.ovale,
this.debug,
this.aura,
combat,
this.paperDoll,
this.spellBook
);
this.stance = new OvaleStanceClass(
this.debug,
this.ovale,
Expand Down Expand Up @@ -467,6 +477,7 @@ export class IoC {
this.state.registerState(this.paperDoll);
this.state.registerState(this.baseState);
this.state.registerState(this.demonHunterSigils);
this.state.registerState(this.eclipse);
this.state.registerState(this.enemies);
this.state.registerState(this.future);
this.state.registerState(this.health);
Expand All @@ -487,6 +498,7 @@ export class IoC {
soulbind.registerConditions(this.condition);
this.warlock.registerConditions(this.condition);
this.aura.registerConditions(this.condition);
this.eclipse.registerConditions(this.condition);
this.future.registerConditions(this.condition);
this.paperDoll.registerConditions(this.condition);
this.equipment.registerConditions(this.condition);
Expand Down
Loading