BBB-01 | Lack Of Input Validation #3171

Added input validation on BridgeBank _initialize function.
Sifchain · Sep 22, 2022 · af13c11 · af13c11
1 parent 48dded4
commit af13c11
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/smart-contracts/contracts/BridgeBank/BridgeBank.sol b/smart-contracts/contracts/BridgeBank/BridgeBank.sol
@@ -143,6 +143,12 @@ contract BridgeBank is BankStorage, CosmosBank, EthereumWhiteList, CosmosWhiteLi
     int32 _networkDescriptor,
     address _rowanTokenAddress
   ) private {
+
+    require(_operator != address(0), "invalid _operator address");
+    require(_cosmosBridgeAddress != address(0), "invalid _cosmosBridgeAddress address");
+    require(_owner != address(0), "invalid _owner address");
+    require(_networkDescriptor >= 0 && _networkDescriptor <= 9999, "invalid _networkDescriptor");
+
     Pausable._pausableInitialize(_pauser);
 
     operator = _operator;