BBB-01 | Lack Of Input Validation

[Brando753]

Affected Files: BridgeBank.sol L128

Description

In the smart-contracts/contracts/BridgeBank/BridgeBank contract, the given inputs of the _initialize function are missing the sanity check.

function _initialize(
    address _operator,
    address _cosmosBridgeAddress,
    address _owner,
    address _pauser,
    int32 _networkDescriptor
  ) private {
    Pausable._pausableInitialize(_pauser);

    operator = _operator;
    cosmosBridge = _cosmosBridgeAddress;
    owner = _owner;
    networkDescriptor = _networkDescriptor;
  }

Recommendation

Recommend adding the check for the passed-in values to prevent unexpected error. For example:

require(_operator != address(0),"invalid _operator address");
require(_cosmosBridgeAddress != address(0),"invalid _cosmosBridgeAddress address");
require(_owner != address(0),"invalid _owner address");
require(_networkDescriptor>=0 && _networkDescriptor<=999,
        "invalid _cosmosBridgeAddress address");

[Brando753]

#3279 PR opened