Skip write to time_series_v4 table for the same fingerprint in curren… #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srikanthccv
requested review from
ankitnayan,
makeavish,
nityanandagohain and
prashant-shahi
as code owners
|
@srikanthccv the code changes are the same, please add a description on why it was reverted and how we have fixed the issue because of which it's added back. |
|
Updated! |
nityanandagohain
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t hour
Resubmission of #335
The previous version of the change considered only fingerprint but not time. It fails when the entry is added at the current hour :15 minutes. This resubmission includes the unixmilli as part of cache key. This will ensure there will be one fingerprint inserted if the hour changes.