New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: write int64 tag attributes for old schema #373

Merged

nityanandagohain merged 2 commits into main from issue_372

Aug 27, 2024

Member

nityanandagohain commented Aug 27, 2024

Fixes #372

with the new schema we stored in64 tag attributes as float64 which broke the suggestions api for old users with int64 keys.
this PR fixes this issue and also adds a new config option.


          fix: write int64 tag attributes for old schema

69ae344

nityanandagohain requested review from ankitnayan, makeavish, prashant-shahi and srikanthccv as code owners

August 27, 2024 10:08


          fix: add test config

36dfc54

srikanthccv approved these changes

View reviewed changes

nityanandagohain merged commit a324347 into main

2 checks passed

nityanandagohain deleted the issue_372 branch

August 27, 2024 10:39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

srikanthccv srikanthccv approved these changes

ankitnayan Awaiting requested review from ankitnayan ankitnayan is a code owner

makeavish Awaiting requested review from makeavish makeavish is a code owner

prashant-shahi Awaiting requested review from prashant-shahi prashant-shahi is a code owner