Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

404 Page for wrong url redirection #135

Closed
muddlebee opened this issue May 30, 2021 · 8 comments · Fixed by #217
Closed

404 Page for wrong url redirection #135

muddlebee opened this issue May 30, 2021 · 8 comments · Fixed by #217
Assignees
Labels
enhancement New feature or request frontend good first issue Good for newcomers

Comments

@muddlebee
Copy link
Contributor

muddlebee commented May 30, 2021

Bug description

404 Page for wrong url redirection

Goto http://localhost:3000/xyz -> Empty page opening
xyz doesn't exist.

Please describe.
If this affects the front-end, screenshots would be of great help.
Screenshot 2021-05-30 at 3 41 55 PM

Expected behavior

Goto http://localhost:3000/xyz -> 404 Error Page

How to reproduce

  1. Go to http://localhost:3000/xyz or any random suffix after the base URL (http://localhost:3000)
  2. Page with empty content

Additional context

Thank you for your bug report – we love squashing them!

@muddlebee muddlebee added frontend enhancement New feature or request good first issue Good for newcomers labels May 30, 2021
@muddlebee
Copy link
Contributor Author

some UI inspiration:

image

image

@saideepesh000
Copy link
Contributor

@ankitnayan @pranay01 can you provide any adobe or Figma design that you from your team

@saideepesh000 saideepesh000 self-assigned this Jun 18, 2021
@pranay01
Copy link
Collaborator

@saideepesh000 Will provide one by tomorrow

@pranay01 pranay01 self-assigned this Jun 18, 2021
@pranay01
Copy link
Collaborator

@saideepesh000 Here's the figma design https://www.figma.com/file/9yU6x8Z6YYoVk01HJQRSIF/SigNoz-OSS-Github-Issues-UI?node-id=2%3A21
Let me know if you are not able to access it

  • If user enters <base_url>/xyz123 as the url, he should be shown
    Home > xyz123 in top bread crumb ( i think this will happen by default)

  • The 'Return to Metrics page' button should take user the /application page

  • Test this for both light and dark mode ( buttons, text are legible)

Screenshot 2021-06-19 at 11 38 47 PM

@pranay01
Copy link
Collaborator

SVG file for the graphic used in the design - https://drive.google.com/drive/folders/1CTifClWIxGbomiQJlb4YGPhjhj_ZXe_A?usp=sharing

@pranay01 pranay01 removed their assignment Jun 19, 2021
@palashgupta98
Copy link
Contributor

@saideepesh000 are you working on this one ?

@saideepesh000
Copy link
Contributor

Hey @palashgdev , yeah I would work on it, but not right now, I'm on my exams, so meanwhile if you want you can take it.

@palashgupta98
Copy link
Contributor

@saideepesh000 sure would like to take this one ... @ankitnayan can you please assign this one to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants