Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FE): add Not Found Route #217

Merged
merged 16 commits into from Jul 30, 2021

Conversation

palashgupta98
Copy link
Contributor

@palashgupta98 palashgupta98 commented Jul 9, 2021

this issue fixes #135

Dark Mode

Screenshot 2021-07-14 at 11 46 09 PM

Light Mode

Screenshot 2021-07-14 at 11 47 58 PM

@palashgupta98 palashgupta98 marked this pull request as ready for review July 10, 2021 08:39
@nidhi-tandon
Copy link
Contributor

Please update the PR description. The issue link is not correct.
Also please add a detailed description of the PR changes. If possible, add screenshots as well of the new screen introduced.

Copy link
Contributor

@nidhi-tandon nidhi-tandon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added few comments.

@nidhi-tandon nidhi-tandon changed the title Fix/not found route feat(FE): add Not Found Route Jul 10, 2021
frontend/src/components/NotFound/index.tsx Outdated Show resolved Hide resolved
frontend/src/components/NotFound/styles/ButtonContainer.ts Outdated Show resolved Hide resolved
frontend/src/modules/AppWrapper.tsx Outdated Show resolved Hide resolved
@palashgupta98
Copy link
Contributor Author

Please update the PR description. The issue link is not correct.
Also please add a detailed description of the PR changes. If possible, add screenshots as well of the new screen introduced.

Updated

@palashgupta98 palashgupta98 self-assigned this Jul 16, 2021
Copy link
Collaborator

@ankitnayan ankitnayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2021-07-29 at 6 04 49 PM

@palashgdev you might want to have a look at this. Works fine on yarn dev though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

404 Page for wrong url redirection
5 participants