Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lazy loading when showing all the panels in a dashboard #2005

Closed
ankitnayan opened this issue Jan 8, 2023 · 7 comments · Fixed by #2133
Closed

Add lazy loading when showing all the panels in a dashboard #2005

ankitnayan opened this issue Jan 8, 2023 · 7 comments · Fixed by #2133

Comments

@ankitnayan
Copy link
Collaborator

If a dashboard has 20 panels, we load (and hence the API calls) all the panels in one go. It fires 20 concurrent requests to clickhouse. We should add lazy loading here. We should only load the panels when a user scrolls down.

@jyash97
Copy link
Contributor

jyash97 commented Jan 9, 2023

Hey @ankitnayan

Can I take a look at this? I always wanted to give it a try on IntersectionObserver and this seems to be a good use case

@ankitnayan
Copy link
Collaborator Author

sure...assigning this to you @jyash97

@ankitnayan
Copy link
Collaborator Author

@jyash97 I hope you are looking into this. Let us know if you need more context or won't be able to make time

@jyash97
Copy link
Contributor

jyash97 commented Jan 19, 2023

Hey @ankitnayan if you need this urgently, you can assign this issue to someone else or the team

@ankitnayan
Copy link
Collaborator Author

we were looking to make it to the next release on wed, 25th Jan. Let us know if possible

@jyash97
Copy link
Contributor

jyash97 commented Jan 19, 2023

I dont think I would be able to pull this off before 25 Jan. You might assign this to someone else

Thanks

@ankitnayan
Copy link
Collaborator Author

I dont think I would be able to pull this off before 25 Jan. You might assign this to someone else

Thanks

no worries..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants