Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: removed stale make commands #1340

Merged
merged 3 commits into from
Jul 13, 2022
Merged

chore: removed stale make commands #1340

merged 3 commits into from
Jul 13, 2022

Conversation

palashgdev
Copy link
Contributor

@palashgdev palashgdev commented Jun 29, 2022 •
edited

@request-info
Copy link

request-info bot commented Jun 29, 2022

We would appreciate it if you could provide us with more info about this issue/pr!

@sonarcloud
Copy link

sonarcloud bot commented Jul 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

pranshuchittora
pranshuchittora approved these changes Jul 4, 2022
View reviewed changes
Copy link
Contributor

@pranshuchittora pranshuchittora left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ankitnayan ankitnayan merged commit 4d1516e into SigNoz:develop Jul 13, 2022
@ishanvyas22 ishanvyas22 mentioned this pull request Aug 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prashant-shahi prashant-shahi prashant-shahi approved these changes

@pranshuchittora pranshuchittora pranshuchittora approved these changes

@ankitnayan ankitnayan Awaiting requested review from ankitnayan

Assignees

@prashant-shahi prashant-shahi

@ankitnayan ankitnayan

Labels
request-more-info
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@palashgdev @prashant-shahi @pranshuchittora @ankitnayan