1363 externalcall querybuilder #1550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactored the queries into separate file
|
We would appreciate it if you could provide us with more info about this issue/pr! |
|
Close #1363 |
Added logic for resourceattribute to tagFilter items conversion
|
This change aims to convert queries in External tabs from PromQL to QueryBuilder |
|
@pranshuchittora Could you please review. |
sf-pchakraborty
requested review from
palashgdev and
pranshuchittora
as code owners
removed the serial numbers.
Resolved TS related issue
|
@ankitnayan Could you please ask someone to review the changes? It's done from my end. |
refactored the queries into separate file
Added logic for resourceattribute to tagFilter items conversion
removed the serial numbers.
Resolved TS related issue
sf-pchakraborty
force-pushed
the
1363-externalcall-querybuilder
branch
from
40ad59a
to
02c5503
Compare
…f-pchakraborty/signoz into 1363-externalcall-querybuilder
|
@palashgdev Could you please have a look once? |
|
Sure @sf-pchakraborty |
palashgdev
suggested changes
Sep 20, 2022
frontend/src/container/MetricsApplication/MetricsPageQueries/ExternalQueries.tsx
Outdated
Show resolved
Hide resolved
frontend/src/container/MetricsApplication/MetricsPageQueries/ExternalQueries.tsx
Outdated
Show resolved
Hide resolved
frontend/src/container/MetricsApplication/MetricsPageQueries/ExternalQueries.tsx
Outdated
Show resolved
Hide resolved
frontend/src/container/MetricsApplication/MetricsPageQueries/ExternalQueries.tsx
Outdated
Show resolved
Hide resolved
frontend/src/container/MetricsApplication/MetricsPageQueries/ExternalQueries.tsx
Outdated
Show resolved
Hide resolved
…f-pchakraborty/signoz into 1363-externalcall-querybuilder
sf-pchakraborty
commented
Sep 30, 2022
There was a problem hiding this comment.
@palashgdev requested changes have been pushed. Please review. Thanks
|
Kudos, SonarCloud Quality Gate passed!
|
palashgdev
approved these changes
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change aims to convert queries in External tabs from PromQL to QueryBuilder
Close #1363