-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: route and breadcrumbs renamed to services #1566
feat: route and breadcrumbs renamed to services #1566
Conversation
route and breadcrumbs for metrics used to show application. Have updated it to services. Also 'Page Not Found ' pages have been updated to show services instead of metrics.
@sf-pchakraborty I am not sure why contribution.md is changed can you please revert this one |
apart from this one LGTM 👍 |
@palashgdev resolved conflicts and reverted changes made in security.md, it wasn't required. |
@sf-pchakraborty can you please turn off the lint or install mdx lint As this would be too and fro for other folks also |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks @sf-pchakraborty for making the change :-D
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
route and breadcrumbs for metrics used to show application. Have updated it to services. Also 'Page Not Found ' pages have been updated to show services instead of metrics.
Please close the following issues -
Close #1310
Also #1565