Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: route and breadcrumbs renamed to services #1566

Conversation

sf-pchakraborty
Copy link
Contributor

route and breadcrumbs for metrics used to show application. Have updated it to services. Also 'Page Not Found ' pages have been updated to show services instead of metrics.

Please close the following issues -

Close #1310

Also #1565

route and breadcrumbs for metrics used to show application. Have updated it to services.
Also 'Page Not Found ' pages have been updated to show services instead of metrics.
@palashgdev
Copy link
Contributor

@sf-pchakraborty I am not sure why contribution.md is changed can you please revert this one

@palashgdev
Copy link
Contributor

apart from this one LGTM 👍

@sf-pchakraborty
Copy link
Contributor Author

@palashgdev resolved conflicts and reverted changes made in security.md, it wasn't required.

@palashgdev
Copy link
Contributor

@sf-pchakraborty can you please turn off the lint or install mdx lint

As this would be too and fro for other folks also

Copy link
Contributor

@palashgdev palashgdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @sf-pchakraborty for making the change :-D

@sonarcloud
Copy link

sonarcloud bot commented Sep 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ankitnayan ankitnayan merged commit 1b1fb2f into SigNoz:develop Oct 3, 2022
@sf-pchakraborty sf-pchakraborty deleted the 1310-update-route-breadcrumbs-to-services branch October 16, 2022 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the name of the route and breadcrumb to include Services
3 participants