Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filter items can be empty #1586

Merged
merged 3 commits into from
Sep 27, 2022
Merged

fix: filter items can be empty #1586

merged 3 commits into from
Sep 27, 2022

Conversation

srikanthccv
Copy link
Member

@srikanthccv srikanthccv commented Sep 21, 2022

The formula part (or even the named query) of query builder doesn't include the tagFilters in the request payload so it should be handled without throwing error.

Fixes #1583

@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the bug Something isn't working label Sep 21, 2022
@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@srikanthccv srikanthccv marked this pull request as ready for review September 21, 2022 09:38
@sonarcloud
Copy link

sonarcloud bot commented Sep 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ankitnayan ankitnayan merged commit 2c9794a into develop Sep 27, 2022
@ankitnayan ankitnayan deleted the issue-1583 branch September 27, 2022 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working codeball:needs-careful-review Codeball
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Formula expects the empty entry for filter set
2 participants